Skip to content

fix: block full 172 private host range - #1442

Closed
silentgeckoaudit3801 wants to merge 2 commits into
LabsCrypt:mainfrom
silentgeckoaudit3801:fix-private-host-172-16-range-1339
Closed

fix: block full 172 private host range#1442
silentgeckoaudit3801 wants to merge 2 commits into
LabsCrypt:mainfrom
silentgeckoaudit3801:fix-private-host-172-16-range-1339

Conversation

@silentgeckoaudit3801

Copy link
Copy Markdown

Closes #1339

Summary:

  • Expand the private-host guard to cover the full RFC1918 172.16.0.0/12 range, including 172.16.x.x.
  • Export the helper so the boundary logic can be tested directly.
  • Add regression coverage for 172.16/172.31 being blocked and neighboring public 172.15/172.32 ranges remaining allowed.

Validation:

  • Static GitHub API/source inspection only; local backend dependency or test commands were not run to avoid installing or executing project dependencies in this environment.

@ogazboiz

ogazboiz commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

thanks for the PR. this was a real bug when you branched, but the same fix already landed on main: indexerController.ts:39 already blocks the full 172.16-31 private range. since the change is now redundant, closing this one to keep the queue clean. please branch from current main before your next fix PR, and feel free to reopen if I misread anything. if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

@ogazboiz ogazboiz closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Backend] SSRF: private-range guard misses part of the 172.16.0.0/12 block

2 participants